From e98b20bc819c1d5f898de27d55680da52ae0041c Mon Sep 17 00:00:00 2001 From: Dobrin Dimchev Date: Wed, 20 Mar 2024 21:04:29 +0200 Subject: [PATCH] fix: remove test code and fix bg color --- packages/fiori/src/DynamicPage.ts | 2 +- .../sap_horizon_dark/DynamicPageTitle-parameters.css | 5 ----- .../src/themes/sap_horizon_dark/parameters-bundle.css | 2 +- .../website/docs/_samples/fiori/DynamicPage/Basic/main.js | 8 -------- 4 files changed, 2 insertions(+), 15 deletions(-) delete mode 100644 packages/fiori/src/themes/sap_horizon_dark/DynamicPageTitle-parameters.css diff --git a/packages/fiori/src/DynamicPage.ts b/packages/fiori/src/DynamicPage.ts index da0ccc31747a..bc785ec8816a 100644 --- a/packages/fiori/src/DynamicPage.ts +++ b/packages/fiori/src/DynamicPage.ts @@ -31,7 +31,7 @@ import { DYNAMIC_PAGE_ARIA_LABEL_SNAPPED_HEADER, } from "./generated/i18n/i18n-defaults.js"; -const SCROLL_DEBOUNCE_RATE = 25; // ms +const SCROLL_DEBOUNCE_RATE = 5; // ms /** * @class diff --git a/packages/fiori/src/themes/sap_horizon_dark/DynamicPageTitle-parameters.css b/packages/fiori/src/themes/sap_horizon_dark/DynamicPageTitle-parameters.css deleted file mode 100644 index 8da5b5fd1d37..000000000000 --- a/packages/fiori/src/themes/sap_horizon_dark/DynamicPageTitle-parameters.css +++ /dev/null @@ -1,5 +0,0 @@ -@import "../base/DynamicPageTitle-parameters.css"; - -:root { - --_ui5_dynamic_page_title_hover_background: transparent; -} \ No newline at end of file diff --git a/packages/fiori/src/themes/sap_horizon_dark/parameters-bundle.css b/packages/fiori/src/themes/sap_horizon_dark/parameters-bundle.css index cbbb1f7ecf03..f0933baa5747 100644 --- a/packages/fiori/src/themes/sap_horizon_dark/parameters-bundle.css +++ b/packages/fiori/src/themes/sap_horizon_dark/parameters-bundle.css @@ -1,6 +1,6 @@ @import "../base/sizes-parameters.css"; @import "../base/DynamicPage-parameters.css"; -@import "./DynamicPageTitle-parameters.css"; +@import "../base/DynamicPageTitle-parameters.css"; @import "../base/DynamicPageHeader-parameters.css"; @import "../sap_horizon/DynamicPageHeaderActions-parameters.css"; @import "../base/Bar-parameters.css"; diff --git a/packages/website/docs/_samples/fiori/DynamicPage/Basic/main.js b/packages/website/docs/_samples/fiori/DynamicPage/Basic/main.js index 236d12be5cd1..a307aae5b384 100644 --- a/packages/website/docs/_samples/fiori/DynamicPage/Basic/main.js +++ b/packages/website/docs/_samples/fiori/DynamicPage/Basic/main.js @@ -26,20 +26,12 @@ const editButton = document.querySelector("#edit-button"); const cancelEdit = document.querySelector("#cancel-edit"); const saveEdit = document.querySelector("#save-edit"); - -console.error(dynamicPage); -console.error(editButton); -console.error(cancelEdit); -console.error(saveEdit); - editButton.addEventListener("click", () => { - console.error("editButton click"); dynamicPage.setAttribute("show-footer", true); }); [saveEdit, cancelEdit].forEach(button => { button.addEventListener("click", () => { - console.error("saveEdit or cancelEdit click", dynamicPage); dynamicPage.removeAttribute("show-footer"); }); }); \ No newline at end of file