Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some confused #3

Open
YuDe95 opened this issue May 28, 2020 · 1 comment
Open

some confused #3

YuDe95 opened this issue May 28, 2020 · 1 comment

Comments

@YuDe95
Copy link

YuDe95 commented May 28, 2020

in bdf_cards_ctria3.cpp
image

in entry_type.h
image

@berhoel
Copy link
Contributor

berhoel commented May 28, 2020

bdf_cards_ctria3.cpp is easy to fix. Just move the closing bracket for else just before return and thus get rid of the goto.

I am not sure yet how to get rid of the possible problem in entry_type.h. Due to the way the entries are stored and processed the library relies on overloading the format(const void*)method.

I will generate a pull request for bdf_cards_ctria3.cpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants