Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Resource manager incorrect order for Permission Checkboxes #6214

Open
2 of 4 tasks
Timo-Breumelhof opened this issue Nov 21, 2024 · 7 comments
Open
2 of 4 tasks

Comments

@Timo-Breumelhof
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description of problem

When setting the Checkboxes for Folder permissions the order of null - true -block is not ideal.
This is the order when clicking the checkboxes:

GIF 21-11-2024 10-32-50

Description of solution

IMO the order should be the same as for Page rights..

[ ] > [V] > [X]

Description of alternatives considered

No response

Anything else?

No response

Do you be plan to contribute code for this enhancement?

  • Yes

Would you be interested in sponsoring this enhancement?

  • Yes

Code of Conduct

  • I agree to follow this project's Code of Conduct
@valadas
Copy link
Contributor

valadas commented Nov 21, 2024

It uses dnn-elements checkbox and I have an issue to look into that here DNNCommunity/dnn-elements#546

@Timo-Breumelhof
Copy link
Contributor Author

@valadas ah ok so we can close this one..

@jeremy-farrance
Copy link
Contributor

I think that would depend on how Resource Manager uses Dnn Elements. If it bundles/embeds it, then no. If it loads the latest from a CDN, then yes. Which is it? Or am I just wrong about this?

@valadas
Copy link
Contributor

valadas commented Nov 21, 2024

Well, the fix needs to be done there, then the consumed version updated here. But my point was that we need to start there.

As for closing here or not, once we release another version of dnn-elements, dependabot will eventually open a PR to update it and I'll probably not think to come back to this issue.

@david-poindexter
Copy link
Contributor

@valadas should this issue now be closed due to #1241 or does that PR not fully address this issue?

@valadas
Copy link
Contributor

valadas commented Dec 28, 2024

I need to publish dnn elements and then update it's version used here

@david-poindexter
Copy link
Contributor

Ah, okay - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants