Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Change from Log4net to Serilog #6181

Open
3 of 4 tasks
donker opened this issue Nov 1, 2024 · 1 comment
Open
3 of 4 tasks

[Enhancement]: Change from Log4net to Serilog #6181

donker opened this issue Nov 1, 2024 · 1 comment

Comments

@donker
Copy link
Contributor

donker commented Nov 1, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Description of problem

DNN Currently uses Log4net for logging. It is also included as a DNN branded fork of log4net which makes us vulnerable. Although log4net has served as well over the years, there are newer solutions that provide us with features log4net cannot offer.

Note this issue is a continuation of issue #2801

Description of solution

The solution is to deprecate the old log4net library included with DNN and move to (non-forked) Serilog. Serilog offers many more sinks and can be configured to clean up the log directory. It would also provide an opportunity to move the DotNetNuke.Instrumentation library to .net standard.

Description of alternatives considered

The alternative considered is keeping log4net and updating the existing code to keep in sync with the original project. Because our code includes CodeCop fixes this will be a time-consuming process.

Anything else?

No response

Do you be plan to contribute code for this enhancement?

  • Yes

Would you be interested in sponsoring this enhancement?

  • Yes

Code of Conduct

  • I agree to follow this project's Code of Conduct
@mitchelsellers
Copy link
Contributor

THanks @donker for bringing this back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Awaiting Triage
Development

No branches or pull requests

3 participants