-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What does this mean? #149
Comments
As stated in the readme, CWL support is under active development. You can consider it "alpha" right now. Your pipeline likely uses some features that are not yet supported. |
Thanks, what stage is WDL on? And also what maybe the best resource to look at for directly creating DNAnexus applet workflows using scripting and not through the interface? Thanks for your help. |
WDL is ready for use. Is the example at https://github.com/dnanexus/dxCompiler/#example-workflow enough to get you started? |
Yes I know WDL, I was referring to writing straight DNAnexus workflow applets using coding, i.e. skip the WDL or CWL conversion step. |
xVantage Care Support team sent the following response via ticket tracking system (SF27964): Based on our investigation, it appears that your CWL workflow is designed for CWL 1.0. And as it has been already mentioned here (#149) - CWL 1.2 support are under active development. "WDL draft-2 and versions 1.0 and 1.1 are fully supported, while WDL 2.0 (aka 'development') and CWL 1.2 support are under active development." [https://github.com/dnanexus/dxCompiler/] As our dxCompiler-2.4.7.jar testing example, we were able to successfully build a CWL workflow (written in version 1.2.): using the following command java -jar dxCompiler-2.4.7.jar compile /Users/oklempir-cf/Downloads/cwl-v1.2-main/tests/dynresreq-workflow-inputdefault.cwl -project SF27964 -folder /cwl_test/ In order to convert your code from 1.0 to 1.2, you may find the following conversion/normalizer tool useful (it is created by the main developer of CWL language https://github.com/common-workflow-language/cwl-utils Please note that this is an untested suggestion and we have not tested this conversion tool on any workflow available at https://github.com/genome/analysis-workflows/ If you wish to write your custom straight DNAnexus workflow applets using coding, we recommend using the following doc page on how to start writing custom made app(let)s. There are several ways how to implement your applets, e.g. with Python or Bash: https://documentation.dnanexus.com/developer/apps https://documentation.dnanexus.com/developer/apps/intro-to-building-apps |
So I updated my pipeline to v1.2 and still get same issue
We have the four types here: https://github.com/genome/analysis-workflows/tree/master/definitions/types Can you test if dxCompiler works for a schemadef as in: https://github.com/common-workflow-language/cwl-v1.2/blob/main/tests/anon_enum_inside_array_inside_schemadef.cwl UPDATE, this |
So I figured out what the issue is. As in the spec for CWL v1.2 you are allowed to list import types and use them as arrays with the syntax:
where See https://www.commonwl.org/v1.2/Workflow.html#SchemaDefRequirement and here is example ( Additionally answer see here on biostars: https://www.biostars.org/p/259322/ |
Thanks @BJWiley233, we've been working on a stable version of CWL (v2.10) and have fixed a couple of issues related parsing of identifiers. We'll incorporate the example you posted into our test suite and check if it this can be considered fixed. |
I ran code just to test converting CWL pipeline below:
java -jar dxCompiler-2.4.7.jar compile /Users/****/****/UKBB/analysis-workflows/definitions/pipelines/CH_exome_Final2.cwl -language CWL -project UKBB_Exome_2021 -folder /CH_Exome/
And I get this error. What do I have to do/create/make/add to clear this error? Any advice is welcomed.
The text was updated successfully, but these errors were encountered: