Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up these uploads if error encountered? #31

Open
godotgildor opened this issue Sep 9, 2019 · 0 comments
Open

Clean up these uploads if error encountered? #31

godotgildor opened this issue Sep 9, 2019 · 0 comments

Comments

@godotgildor
Copy link

Currently, we upload the RunInfo.xml and sample sheet in this script. We then call the dx_sync_directory.py. If we encounter an error in that (say it throws an exception) then we will have not uploaded any files except these two. The next time the upload routine occurs, we'll upload these two files again, encounter the error again, an it will carry on ad infinitum. Should we at least consider cleaning up these two files if the call to dx_sync_directory.py fails?

https://github.com/dnanexus-rnd/dx-streaming-upload/blob/8fec7ae047504b6b39996dd52e52dd684306e518/files/incremental_upload.py#L359-L362

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant