Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskType can be non-ROOT also for DAGMAN's #45

Open
belforte opened this issue May 21, 2018 · 3 comments
Open

TaskType can be non-ROOT also for DAGMAN's #45

belforte opened this issue May 21, 2018 · 3 comments

Comments

@belforte
Copy link
Member

with ref. to
https://github.com/bbockelm/cms-htcondor-es/blob/master/src/htcondor_es/convert_to_json.py#L532
there are now more DAGs around in for CRAB due to automatic splitting which have task name other than ROOT yet do are not grid jobs.
We need a more solid way to tell things, and to communicate to developers what they can (not) do.

@belforte belforte changed the title TaskType c TaskType can be non-ROOT also for DAGMAN's May 21, 2018
@stiegerb
Copy link
Collaborator

stiegerb commented Nov 6, 2018

@belforte is this still relevant? Can you propose a fix?

@belforte
Copy link
Member Author

belforte commented Nov 6, 2018

it is still relevant. I will look for a crude fix. Proper solution is to complete the rationalization work as per
https://its.cern.ch/jira/browse/CMSMONIT-41

@belforte
Copy link
Member Author

belforte commented Nov 6, 2018

crude fix is to replace this line

if ad.get("TaskType") == "ROOT":

with

if ad.get("TaskType") != "Job":

but I really would like to stop using TaskType there !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants