Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a message when permission fails #545

Open
dynamic-entropy opened this issue Jun 27, 2023 · 7 comments
Open

Return a message when permission fails #545

dynamic-entropy opened this issue Jun 27, 2023 · 7 comments
Assignees

Comments

@dynamic-entropy
Copy link
Contributor

"Permission denied" is many times not enough and cryptic, when permission is very conditional, for e.g. perm_add_rule.
It would be nice to also display a reason.

@dynamic-entropy dynamic-entropy added the triage Issues that need investigation before action label Sep 29, 2023
@Panos512 Panos512 self-assigned this Oct 4, 2023
@ericvaandering
Copy link
Member

I don't know why this was marked "High" priority or even put into this quarter as something we will do. I'm going to move this to ideas since as far as I can tell that's all this is.

@dynamic-entropy
Copy link
Contributor Author

Hello @ericvaandering ,
All the users of Auto approval do not get a direct answer as to why their rule did not get created.
Since User rules take away a good chuck of ops workload, we would like to do this feature with priority.
This was a result of my discussion with Dima. Thus ops wants to take this with priority.

@ericvaandering
Copy link
Member

That's fine. When you have something that's more, we can reassess where to put it in the project.

@dynamic-entropy
Copy link
Contributor Author

More what?
Yes, we can reassess this later, but we should try to do it sooner than later. It has been on hold for about 8 months now. I have been able to give some pointers to people in JIRA tickets whenever they ask for answers, but it would be good if the clients could provide them hints by themselves.

@dynamic-entropy dynamic-entropy changed the title Explore the possibility of returning a message when permission fails Return a message when permission fails Mar 18, 2024
@dynamic-entropy
Copy link
Contributor Author

Upstream issue: rucio/rucio#6580

@dynamic-entropy dynamic-entropy removed the triage Issues that need investigation before action label Apr 17, 2024
@dynamic-entropy
Copy link
Contributor Author

This is not done. It requires one to change policy package to return back messages based on which policy caused a permission denial.

@haozturk
Copy link
Contributor

This isn't only related to Auto Approval, but all rule creations and it'd be really helpful to better error messages. See #867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants