Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] GC Torture test is very slow #11030

Closed
david-cortes opened this issue Nov 30, 2024 · 2 comments · Fixed by #11043
Closed

[R] GC Torture test is very slow #11030

david-cortes opened this issue Nov 30, 2024 · 2 comments · Fixed by #11043

Comments

@david-cortes
Copy link
Contributor

I'm not sure what changed recently, but this test suddently became very slow (~1 minute):

xgboost/R-package/tests/testthat/test_gc_safety.R

Line 3 in 5826b02

test_that("train and prediction when gctorture is on", {

As it is right now, it accounts for more than half of the running time of tests. Perhaps it could be disabled by default and only run on some selected CI job.
@trivialfis
Copy link
Member

Let me bisect it a little bit.

@trivialfis
Copy link
Member

trivialfis commented Dec 2, 2024 •
edited
Loading

Yeah, let's remove it. The time is mainly spent inside R instead of XGBoost. I don't think the test is essential.

I'm not sure what changed recently,

I'm not sure either, going back to the prior release doesn't improve the performance either.

@david-cortes david-cortes mentioned this issue Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[R] Remove GC safety test david-cortes/xgboost
2 participants
@david-cortes @trivialfis