-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] tests fail on scikit-learn 1.6 nightlies #10896
Comments
Thank you for sharing and volunteering!
Yes, please let me know if there's anything I can help. I can handle the C++ changes if needed; some checks are done inside |
Ok thanks! Just confirming I am working on this, will hopefully have something to share soon. |
I have a patch that's working for me locally on a couple of different I'll continue working on this there tomorrow. |
Description
The Python package's tests fail with the latest
scikit-learn
nightlies (v1.6.dev0).All the failures appear to be from the estimator checks
scikit-learn
ships to help projects test compliance withscikit-learn
API expectations. Stuff like this:full logs (click me)
Reproducible Example
On an M2 Mac, in a Python 3.11.9 conda environment, built the Python package from source.
Installed the latest
scikit-learn
nightlies.pip uninstall --yes scikit-learn pytest \ --disable-warnings \ --tb=short \ -rs \ ./tests/python/test_with_sklearn.py \ | tee ./out.txt
Saw the failures reported above.
Repeated that same process but with the latest release of
scikit-learn
.pip uninstall --yes scikit-learn pip install --no-deps 'scikit-learn==1.5.2'
All tests passed.
Notes
I found this while testing against this in-progress
scikit-learn
branch: scikit-learn/scikit-learn#28901 (comment)@trivialfis @hcho3 I'd be happy to try to help with this over the next week if you'd like. I'm familiar with some of the changes in
scikit-learn
from this related work we've been doing inlightgbm
:scikit-learn>=0.24.2
, make scikit-learn estimators compatible withscikit-learn>=1.6.0dev
microsoft/LightGBM#6651The text was updated successfully, but these errors were encountered: