Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localStorage support check borks in packaged Chrome app #50

Open
GoogleCodeExporter opened this issue Oct 30, 2015 · 2 comments
Open

localStorage support check borks in packaged Chrome app #50

GoogleCodeExporter opened this issue Oct 30, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Create a chrome packaged app
2. Try using dat.gui
3. Observe error

What is the expected output? What do you see instead?
Expect that it will work. Instead, an error is thrown because packaged apps 
don't support window.localStorage.
"window.localStorage is not available in packaged apps. Use 
chrome.storage.local instead."

The check for local storage support is failing in this environment. Ideally, it 
will use chrome.storage.local if it is required and available.

    var SUPPORTS_LOCAL_STORAGE = ...


What version of the product are you using? On what operating system?
Used dat.gui.js from build directory in this repo. Chrome latest. MacOSX.


Original issue reported on code.google.com by [email protected] on 18 Jun 2014 at 8:30

@GoogleCodeExporter
Copy link
Author

Isn't this issue just a duplicated of #47?

Original comment by [email protected] on 26 Jul 2014 at 5:45

@GoogleCodeExporter
Copy link
Author

Oh, yep. Suppose we can close this one.

Original comment by [email protected] on 26 Jul 2014 at 7:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant