-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints and set up Mypy #58
Comments
I think Debian Jessie ships Python |
@gmacon This sounds great. I have no issues with Python 3.5 as the minimum requirement. Ubuntu 16.04 comes with Python 3.5, and it's olllllllllld. Doesn't seem like attrs-vs-data-classes will be too hard to combine, and it is indeed probably worth supporting Python 3.5-3.6. |
I've realized that using data classes or attrs-as-data-classes requires Python 3.6 to get the variable annotation syntax. To keep 3.5, we'll need to use attrs unconditionally. |
I got a tad bit carried away earlier, and I did some data modeling on the environment, wrote a parser, and wrote tests for it. I've pushed that up to a branch, but I can open a WIP PR with it if folks would prefer that mechanism for discussing. The question here is basically "do I have the right data model?" |
A mere 3 years later (:sweat_smile:), I started trying to do something similar in the typing_annotations branch. |
OK, as I mentioned in #53 (comment), I've started thinking about setting up Mypy to try to catch some of these silly errors.
Here's what I've come up with so far:
>=3.3
. Would there be any objection to raising the minimum supported version to 3.5?The text was updated successfully, but these errors were encountered: