Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On moving forward with the project #33

Open
ZILtoid1991 opened this issue Sep 1, 2022 · 1 comment
Open

On moving forward with the project #33

ZILtoid1991 opened this issue Sep 1, 2022 · 1 comment

Comments

@ZILtoid1991
Copy link

I've decided to take up the task of finishing the library and getting it into a more usable state.

However, to make the task more reasonable and achieveable, I have to both drop some functions (such as the allocators and the custom error handling) and merge the optional validation into the parsing phase.

I see some potential in this library, and now I posess both the skills and time to fix it, however my visions for an XML library might not be the same as many others, especially of those in control of the Phobos library. My question is that should I just create my own dub library with my improved code, or try to submit it to Phobos inclusion despite the library no longer having an @nogc option?

@burner
Copy link
Contributor

burner commented Sep 1, 2022

Awesome

I have to both drop some functions (such as the allocators and the custom error handling) and merge the optional validation into the parsing phase.

Even more awesome.

I would suggest to put your code into a dub package on code.dlang.org and then push for phobos inclusion.

I think nogc for a parser that builds a try is a bad idea.
If I had the time, I would remove all the allocator code and try to make it @safe and very simple to use.

Thank you for taking this one. Please inform us how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants