Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispense with SenseInventoryResourceBase abstraction for SenseInventory #44

Open
logological opened this issue Jun 24, 2015 · 0 comments

Comments

@logological
Copy link
Member

Originally reported on Google Code with ID 44

When DKPro WSD was originally designed, we decided to abstract sense inventories with
the interface SenseInventory.  This interface provides basic methods for accessing
sense inventories, but is not itself UIMA-specific.  UIMA-specific behaviour is encapsulated
in a further abstraction layer, the SenseInventoryResourceBase class.

The idea behind this two-level abstraction is that it allows SenseInventory-implementing
classes to be used with non-UIMA applications.  However, I'm now questioning whether
anyone would ever want to do this.  The two levels of abstraction result in increased
complexity (and hence increased maintenance requirements, and increased opportunities
for bugs).

Perhaps in a future release of DKPro WSD we could refactor our code so that we have
only one level of abstraction rather than two.  For example, there would be no need
for both a LsrSenseInventory class and a LsrSenseInventoryResource class; all the required
functionality (both UIMA-specific and UIMA-agnostic) would be implemented in LsrSenseInventory.

Reported by [email protected] on 2013-11-08 16:21:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant