Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move non-Wikipedia-specific graph code from graphconnectivity.wikipedia to graphconnectivity #37

Open
logological opened this issue Jun 24, 2015 · 1 comment

Comments

@logological
Copy link
Member

Originally reported on Google Code with ID 37

When fixing Issue 34 it turned out all the code in the graphconnectivity.iterative.*
packages depends on JWPL and/or DKPro Similarity's Wikipedia API.  From reading the
comments I assume this wasn't meant to be so; the graphconnectivity.iterative and graphconnectivity.iterative.util
packages were supposed to be generic classes for iterative graph connectivity algorithms,
and the Wikipedia-specific versions of these are supposed to be in graphconnectivity.iterative.wikipedia
and graphconnectivity.iterative.wikipedia.util.  But code in the former two packages
is actually dependent on classes from the latter two packages.  So for now all of them
have been split off into a separate module, de.tudarmstadt.ukp.dkpro.wsd.graphconnectivity.wikipedia.

In the future it would be great if we could remove the Wikipedia dependencies from
the graphconnectivity.iterative and graphconnectivity.iterative.util packages and move
the classes back to the de.tudarmstadt.ukp.dkpro.wsd.graphconnectivity module.

Reported by [email protected] on 2013-10-08 17:14:50

@logological
Copy link
Member Author

Reported by [email protected] on 2013-11-20 15:02:48

  • Labels removed: Milestone-Release1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant