Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update desi_bayez.py #4

Open
NobleKennamer opened this issue Jun 21, 2016 · 1 comment
Open

Update desi_bayez.py #4

NobleKennamer opened this issue Jun 21, 2016 · 1 comment

Comments

@NobleKennamer
Copy link
Collaborator

@dkirkby @fjaviersanchez

The pull request for updating bayez to the new specsim api is almost completed I just need to finish the update on desi_bayez. I think the main thing that needs to be changed is that the downsample method should be removed from that file entirely and probably placed in another module all together. Should we create something like a helper module to migrate functions like migrate to? What do you think the best approach is for changing this file.

I'm also not sure how these changes should be tested.

@dkirkby
Copy link
Owner

dkirkby commented Jun 21, 2016

I suggest moving the downsample function to the existing analysis module.

It should be straightforward to unit test downsample, especially after cleaning up its API. It would also be useful to have some end-to-end tests that integrate the lower-level components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants