Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining Issues for OpenAl #3886

Open
6 of 10 tasks
benlp91 opened this issue Feb 16, 2025 · 2 comments
Open
6 of 10 tasks

Remaining Issues for OpenAl #3886

benlp91 opened this issue Feb 16, 2025 · 2 comments
Assignees

Comments

@benlp91
Copy link
Contributor

benlp91 commented Feb 16, 2025

@PieterVdc PieterVdc moved this to In Progress in Release 1.3 Feb 16, 2025
@xtremeqg
Copy link
Contributor

i don't know if we want this again, but before OpenAL you were able to dynamically change the sound ingame with the slider and hear live the change you're doing. right now you need to wait until it's over / and or close the menu

This one appears invalid:

  • The "master" volume slider on the main menu works as intended (ticks change volume as you slide).
  • The "master" volume slider on the in-game menu works as intended (ticks change volume as you slide, currently active sound effects change volume).
  • The "music" volume slider on the in-game menu works as intended (music changes volume as you slide, albeit a bit fast) note: this is SDL mixer, not OpenAL.
  • The "mentor" volume slider on the in-game menu works as intended? (master volume changes are applied immediately to mentor speech, mentor volume slider changes are applied to future mentor speech).

@xtremeqg
Copy link
Contributor

These two are the same issue:

Speeches are not allowed to went missing for whatever reasons. (only if you frameskip really much) i think maybe even speeches had their own soundcount and soundlist of 16.

it seems to be messy if the vanilla narrator tells something and the custom narrator aswell, i think sometimes speeches get lost because of this or the order gets messy

@benlp91 benlp91 closed this as completed Feb 17, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Release 1.3 Feb 17, 2025
@benlp91 benlp91 reopened this Feb 17, 2025
@benlp91 benlp91 moved this from Done to In Progress in Release 1.3 Feb 17, 2025
@xtremeqg xtremeqg changed the title remaining Issues for OpenAl Remaining Issues for OpenAl Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants