Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide clearer error messages when no driver is configured in the offline runner #4

Open
andrewpillar opened this issue Apr 25, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@andrewpillar
Copy link
Collaborator

Version djinn devel +b2456a5 Sat Apr 24 16:50:25 2021 +0100 linux/amd64

Environment --

Describe the bug
Segfault happens when you run the offline runner with an empty driver.conf file,

[main][~/code/djinn-ci/djinn]$ cat ~/.config/djinn/driver.conf
[main][~/code/djinn-ci/djinn]$ djinn
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0xa0f214]

goroutine 1 [running]:
main.main()
    /home/andrew/code/djinn-ci/djinn/cmd/djinn/main.go:202 +0x11b4

this should instead just throw up an error complaining about no drivers having been configured.

Reproduction steps
Create an empty driver.conf file and run djinn.

@andrewpillar andrewpillar added the bug Something isn't working label Apr 25, 2021
@andrewpillar andrewpillar self-assigned this Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant