Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to remove READ_MEDIA_IMAGES and READ_MEDIA_VIDEO permissions from Manifest? #446

Open
brien-crean opened this issue Nov 13, 2024 · 3 comments

Comments

@brien-crean
Copy link

Permissions added by SDK 5 are triggering an App Content declaration in Google Play that needs attention soon. Are these permissions required to successfully use the SDK?

I can request more time but wondering if the next update to SDK 5 could address this issue please?

Screenshot 2024-11-13 at 2 42 47 PM

// DJIMainActivity.kt
init {
        permissionArray.apply {
            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
                add(Manifest.permission.READ_MEDIA_IMAGES)
                add(Manifest.permission.READ_MEDIA_VIDEO)
                add(Manifest.permission.READ_MEDIA_AUDIO)
            } else {
                add(Manifest.permission.READ_EXTERNAL_STORAGE)
                add(Manifest.permission.WRITE_EXTERNAL_STORAGE)
            }
        }
    }
@dji-dev
Copy link
Contributor

dji-dev commented Nov 14, 2024

Agent comment from yating.liao in Zendesk ticket #121834:

I am currently verifying the information with the team, please hold on for a moment.

°°°

@dji-dev
Copy link
Contributor

dji-dev commented Nov 15, 2024

Agent comment from yating.liao in Zendesk ticket #121834:

We have conducted a preliminary assessment, and it appears that the READ_MEDIA_IMAGES and READ_MEDIA_VIDEO permissions may not be essential for the SDK. However, the results of removing them still need to be verified. I have submitted this issue to the team, and I will update you here once we have a conclusion.

°°°

@brien-crean
Copy link
Author

@dji-dev thank you very much for looking into this, I appreciate that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants