Voucher application with suspended offer

[samar-hassan]

Voucher is being applied even if the only offer attached to the that voucher is suspended.

[maerteijn]

This shouldn't be the case as django-oscar-api is just using the regular django-oscar machinery for applying offers.

In apply_offers, we just call the oscar applicator:

def apply_offers(request, basket):
    "Apply offers and discounts to cart"
    basket.reset_offer_applications()
    if not basket.is_empty:
        Applicator().apply(basket, request.user, request)

In the default oscar applicator, offers are retrieved by using the active Manager:

  def get_site_offers(self):
        """
        Return site offers that are available to all users
        """
        ConditionalOffer = get_model('offer', 'ConditionalOffer')
        qs = ConditionalOffer.active.filter(offer_type=ConditionalOffer.SITE)

The active manager makes sure inactive of suspended offers are not queried, see the unit test for this in oscar:

    def test_filters_out_suspended_offers(self):
        # Create offer that is available but with the wrong status
        factories.create_offer(
            status=models.ConditionalOffer.SUSPENDED)
        filtered_offers = models.ConditionalOffer.active.all()
        self.assertEqual(0, len(filtered_offers))