Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Oscar-independant #58

Open
juanigsrz opened this issue Apr 4, 2018 · 11 comments
Open

Not Oscar-independant #58

juanigsrz opened this issue Apr 4, 2018 · 11 comments

Comments

@juanigsrz
Copy link

Running

pip install django-oscar-accounts
(adding oscar_accounts to installed apps)
python manage.py migrate oscar_accounts

Yields:

SystemCheckError: System check identified some issues:

ERRORS:
oscar_accounts.Account.product_range: (fields.E300) Field defines a relation with model 'offer.Range', which is either not installed, or is abstract.
oscar_accounts.Account.product_range: (fields.E307) The field oscar_accounts.Account.product_range was declared with a lazy reference to 'offer.range', but app 'offer' isn't installed.

@solarissmoke
Copy link
Member

Yeah, unfortunately it isn't. I've actually removed the suggestion that it is from the documentation on master - unless someone has the time to actually make it oscar-independent I think it will probably have to stay that way...

@juanigsrz
Copy link
Author

Looking at the code for a bit i think it only references django-oscar for its user model and an exception class. It also references offer.Range with a ForeignKey which i think could be deleted. So yeah. making it oscar-independant might not be really hard after all.

@solarissmoke
Copy link
Member

Would you be able to make a PR? More than happy to review/merge it if you are.

@juanigsrz
Copy link
Author

juanigsrz commented Apr 5, 2018

Right now i'm busy with two other projects, but i will try to do it if no one else does.

@SalahAdDin
Copy link

what's the possible solution here? If you have time i can help you with this.

@millerf
Copy link

millerf commented Apr 8, 2019

Hi, I would be really interested in using this as a standalone.
@juanigsrz I checked and removing the 'offer.Rang' foreign key doesn't seem so easy, or at least I am not sure on how to actually handle that...

@juanigsrz
Copy link
Author

Hey @millerf , i personally ended up dropping it and made my own double entry system based on other working projects. Sorry i can't help you.

@millerf
Copy link

millerf commented Apr 8, 2019

No worries... I just reused it and removed the product_range attribute...

@juanigsrz
Copy link
Author

As @solarissmoke said, feel free to make a PR for review, i'm sure it'll be helpful to a lot of people!

@PekopT
Copy link

PekopT commented Mar 26, 2020

I'll just leave it here:
https://github.com/PekopT/django-oscar-accounts

@TurnrDev
Copy link
Contributor

TurnrDev commented Nov 5, 2020

I'll just leave it here:
https://github.com/PekopT/django-oscar-accounts

Love the work, any plans to release the work on pypi?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants