Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser-based test #291

Open
divergentdave opened this issue May 10, 2023 · 2 comments
Open

Browser-based test #291

divergentdave opened this issue May 10, 2023 · 2 comments

Comments

@divergentdave
Copy link
Contributor

We should make another private package for a browser-based integration test. It should import the client library, spin up mock HTTP servers for the aggregators, and test the client from within a browser using Selenium or similar.

@jbr
Copy link
Contributor

jbr commented May 11, 2023

Some questions/thoughts:

  • Mock aggregator or actual janus? Is the intent an end-to-end exercise of the system or an integration test for the cli working in-browser?
  • There are two ways people might use the @divviup/dap package -- directly from a cdn in a script tag, or requiring it into an in-browser compiled app like a react app. We probably should test both of these to ensure that the packaging works either way.
  • Do we want to try for multi browser testing with playwright or just use puppeteer for chrome and do manual testing for the other browsers?

@divergentdave
Copy link
Contributor Author

I think a mock aggregator would be fine for this, we've got a separate integration test to cover interop with Janus, and using a mock would help keep the test infrastructure complexity down. I'm mainly interested in confirming that our compilation steps and packaging are working. For that reason, one browser should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants