From baa4c5a1600ea12109f829107c6998cfc976f6c5 Mon Sep 17 00:00:00 2001 From: Tim Geoghegan Date: Wed, 12 Jun 2024 15:51:36 -0700 Subject: [PATCH] `docker-release`: load built images for later push (#1095) Otherwise the `docker push` steps can't see the images, as in [1]: Build step: ``` WARNING: No output specified with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load ``` Push step: ``` The push refers to repository [us-west2-docker.pkg.dev/janus-artifacts/divviup-api/divviup_api_integration_test] An image does not exist locally with the tag: us-west2-docker.pkg.dev/janus-artifacts/divviup-api/divviup_api_integration_test ``` [1]: https://github.com/divviup/divviup-api/actions/runs/9490619255/job/26154435457 --- .github/workflows/docker-release.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/docker-release.yml b/.github/workflows/docker-release.yml index 84ea50d4..f8b9541b 100644 --- a/.github/workflows/docker-release.yml +++ b/.github/workflows/docker-release.yml @@ -33,7 +33,11 @@ jobs: uses: docker/build-push-action@v5 with: context: . + # Do not push in this step so we can push to the private and public repositories + # separately in later steps, but do load so that the images will be visible to `docker + # push` push: false + load: true tags: "${{ steps.resolve_variables.outputs.PUBLIC_TAG}},${{ steps.resolve_variables.outputs.PRIVATE_TAG }}" build-args: | GIT_REVISION=${{ steps.resolve_variables.outputs.GIT_REVISION }}