Update PaymentSplitterDeployer with new factory addresses #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed a splitter via the factory on Goerli and confirmed that the |
|
Thanks for this. Confirming that I understand correctly: these are identical from an ethier perspective, but use the latest OZ deps? Please can you update |
|
That's right, there are no contract changes on either side - just a redeployment with the OZ libraries already installed in the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I deployed a new
PaymentSplitterFactorycontract for mainnet and Goerli. These new deploys use the contracts from OZ 4.7.0, which have a newreleasablefunction (amongst other changes).Mainnet factory: https://etherscan.io/address/0x10af0996e2e289dc8f582e6510b0d251e061bfb5
Goerli factory: https://goerli.etherscan.io/address/0x1353463A30F7A9Eb50A645F4D3950d5d5E41F1F4