Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goldrush is aquired via git: protocol instead of https - causes errors in some environments #624

Open
BitResolution opened this issue Jul 23, 2015 · 2 comments

Comments

@BitResolution
Copy link

Because its using the git protocol some environments are not able to build disco from source due to firewall restrictions.

A workaround appears to be executing the following before buiding disco
git config --global url."https://".insteadOf git://

Please could you adjust the dependency resolution for this artifact? I'll try and put a pull request together.

@pooya
Copy link
Member

pooya commented Jul 24, 2015

Yes. As you see in the following, goldrush is using git://
https://github.com/basho/lager/blob/2.0.3/rebar.config
Disco is using https:
https://github.com/discoproject/disco/blob/develop/master/rebar.config
Fixing this involves forking rebar (which is not a big deal), but is it really necessary if there is such a workaround?

@BitResolution
Copy link
Author

OK 3rd party library issue not really your problem. Maybe worth noting this in the docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants