Fix for Mojolicious 6.40 and above #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constants `DEBUG`, `TEXT`, and `CLOSE` were (in Mojolicious versions below 6.40) defined in `Mojo::Transaction::WebSocket`. They are now (in versions 6.40 and above) defined in `Mojo::WebSocket`, also the `TEXT` and `CLOSE` constants have been renamed with a `WS_` prefix. The `BINARY` constnat has been removed since it turns out this wasn't used in `MojoX::Transaction::WebSocket76`. This commit updates the code to use the new constant names and thus allows the module to work with Mojolicious versions 6.40 and above.
Merged
|
+1 it is works. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the module to use the new location for the constants previously imported from
Mojo::Transation::WebSocket. Their new location is nowMojo::WebSocket. This PR makes the tests pass for Mojolicious versions 6.40 and above (and hence addresses issue #3), however breaks the code for Mojolicious versions below 6.40... Do you also wish to support the older versions in any future release ofMojoX::Transaction::WebSocket76?It turns out that the
build_framemethod has also been moved fromMojo::Transation::WebSocketintoMojo::WebSocketand it has consequently been deprecated. How exactly this issue is to be solved is not clear, however it is good to at least be aware that the method may one day be removed.