Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid signature for mpz.from_bytes() in sphinx docs #90

Open
skirpichev opened this issue Dec 18, 2024 · 4 comments · May be fixed by #140
Open

Invalid signature for mpz.from_bytes() in sphinx docs #90

skirpichev opened this issue Dec 18, 2024 · 4 comments · May be fixed by #140
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers
Milestone
v0.3.0

Comments

@skirpichev
Copy link
Member

skirpichev commented Dec 18, 2024 •
edited
Loading

https://python-gmp.readthedocs.io/en/latest/#gmp.mpz.from_bytes

It miss the bytes argument and it's not rendered as a class method. Looks like a sphinx issue. It should be investigated and reported to upstream.
@skirpichev skirpichev added bug Something isn't working documentation Improvements or additions to documentation labels Dec 18, 2024
@skirpichev skirpichev added this to the v0.2.0 milestone Dec 18, 2024
@skirpichev skirpichev added the good first issue Good for newcomers label Dec 18, 2024
@skirpichev
Copy link
Member Author

Sphinx issue: sphinx-doc/sphinx#13188

@skirpichev skirpichev modified the milestones: v0.2.0, v0.3.0 Dec 22, 2024
skirpichev added a commit to skirpichev/python-gmp that referenced this issue Jan 2, 2025
@skirpichev
Workaround diofant#90
525b8f7
@skirpichev
Copy link
Member Author

525b8f7 should be reverted when fix merged.

@skirpichev skirpichev self-assigned this Jan 4, 2025
skirpichev added a commit that referenced this issue Jan 12, 2025
@skirpichev
+1 workaround #90
485a832
@rruuaanng
Copy link
Contributor

Looks like it's been solved by Bénédikt. Can the issue be closed?

@skirpichev
Copy link
Member Author

Not yet. The fix is not released.

skirpichev added a commit to skirpichev/python-gmp that referenced this issue Jan 21, 2025
@skirpichev
+1 workaround diofant#90
cbb3bc8
skirpichev added a commit to skirpichev/python-gmp that referenced this issue Jan 26, 2025
@skirpichev
Revert workaround for sphinx
5147e28 
Closes diofant#90
@skirpichev skirpichev removed their assignment Jan 26, 2025
@skirpichev skirpichev linked a pull request Jan 26, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Revert workaround for sphinx skirpichev/python-gmp
2 participants
@skirpichev @rruuaanng