Skip to content

Commit

Permalink
fix(server): enable HMR
Browse files Browse the repository at this point in the history
Co-Authored-By: Rafael Falk <[email protected]>
  • Loading branch information
chohner and rbrtrfl committed Nov 18, 2024
1 parent 84d8b1b commit 5a2f5d2
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
4 changes: 2 additions & 2 deletions app/expressApp.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
/* eslint-disable no-console */
/* eslint-disable import/no-named-as-default-member */
/* eslint-disable import/no-named-as-default-member, no-console */
import { createRequestHandler } from "@remix-run/express";
import type { ServerBuild } from "@remix-run/node";
import * as Sentry from "@sentry/remix";
Expand All @@ -11,6 +10,7 @@ import { config } from "./services/env/env.server";
import { createRateLimitRequestHandler } from "./services/rateLimit";
import { createRedisClient, quitRedis } from "./services/redis/redisClient";

// expressApp() itself is not hot reloaded
export const expressApp = (
build: ServerBuild,
viteDevServer: ViteDevServer,
Expand Down
8 changes: 6 additions & 2 deletions server.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,14 @@ const viteDevServer = shouldStartDevServer
: undefined;

const build = viteDevServer
? await viteDevServer.ssrLoadModule("virtual:remix/server-build")
? () => viteDevServer.ssrLoadModule("virtual:remix/server-build")
: await import("./build/server/index.js");

const { app, cleanup } = build.entry.module.expressApp(build, viteDevServer);
// When running a dev server, build() is a function to enable HMR
// To access expressApp(), we need to execute it once
const initialBuild = typeof build === "function" ? await build() : build;
const { expressApp } = await initialBuild.entry.module;
const { app, cleanup } = expressApp(build, viteDevServer);

const port = process.env.PORT || 3000;
const server = app.listen(port, () =>
Expand Down

0 comments on commit 5a2f5d2

Please sign in to comment.