From bbb01b49ffe1e67df3d3401cd702eee9f10afdb9 Mon Sep 17 00:00:00 2001 From: Bruno Grasselli Date: Thu, 16 May 2024 15:22:22 +0200 Subject: [PATCH] Return vpc peering when deleting --- lib/droplet_kit/resources/vpc_peering_resource.rb | 2 +- .../resources/vpc_peering_resource_spec.rb | 15 ++++++++------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/lib/droplet_kit/resources/vpc_peering_resource.rb b/lib/droplet_kit/resources/vpc_peering_resource.rb index 81a09b7..d92651b 100644 --- a/lib/droplet_kit/resources/vpc_peering_resource.rb +++ b/lib/droplet_kit/resources/vpc_peering_resource.rb @@ -38,7 +38,7 @@ class VPCPeeringResource < ResourceKit::Resource end action :delete, 'DELETE /v2/vpc_peerings/:id' do - handler(202) { |_| true } + handler(202) { |response| VPCPeeringMapping.extract_single(response.body, :read) } end end diff --git a/spec/lib/droplet_kit/resources/vpc_peering_resource_spec.rb b/spec/lib/droplet_kit/resources/vpc_peering_resource_spec.rb index e077bcf..16662af 100644 --- a/spec/lib/droplet_kit/resources/vpc_peering_resource_spec.rb +++ b/spec/lib/droplet_kit/resources/vpc_peering_resource_spec.rb @@ -47,7 +47,7 @@ end end - context 'when creating, updating and patching' do + context 'when creating, updating, patching, and deleting' do let(:vpc_peering) do DropletKit::VPCPeering.new( name: 'example-vpc-peering' @@ -105,14 +105,15 @@ let(:arguments) { DropletKit::VPCPeering.new } end end - end - describe '#delete' do - it 'sends a delete request for the vpc' do - request = stub_do_api(File.join(base_path, vpc_peering_uuid), :delete) - resource.delete(id: vpc_peering_uuid) + describe '#delete' do + let(:path) { base_path } + + it 'returns vpc peering pending deletion' do + stub_do_api(File.join(base_path, vpc_peering_uuid), :delete).to_return(body: api_fixture(vpc_peering_fixture_path), status: 202) - expect(request).to have_been_made + expect(resource.delete(id: vpc_peering_uuid)).to match_vpc_peering_fixture + end end end end