You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the new phone number format, phone numbers are written with spaces between them.
This means that when translating this number into rtl languages, their order gets mixed up:
Proposed Solution
Extend the do not translate function with the function that texts keep their direction: e.g. all texts that are marked as do not translate are always ltr
Alternatives
Add an extra button if the municipalities want to keep direction and keep the functionality seperate from do not translate (not recommended bcs it adds extra difficulty and possibilites of making mistakes)
User Story
As a user of the app I want to read the phone number in the correct order, even when using the app in rtl languages so that I always dial the correct number.
As a CMS user I want no extra work when using formatted phone numbers and translating content so that I can keep the time I need to work on Integreat as low as possible.
The <span> element can get a dir="ltr" to achieve that. AFAICT it should not be harmful in any way, as by definition the content is not translated (and should therefore also remain ltr).
As the app sanitizes the content, it might need a change as well.
I couldn't get it to work. I added direction:ltr to the do-not-translate span. That didn't work. Also adding it to the telephone link didn't work.
This is because the parent element <p style="direction: rtl; ;text-align: right;"><a class="link-external" style="direction: ltr;" href="tel:+491111111" data-bcup-haslogintext="no"><span class="notranslate" style="direction: ltr;" translate="no">+49 (0) 1111111</span></a></p> overwrites it with rtl again. I tried to manipulate this and set the closest p to ltr, how a. it was still overwritten and b. even if it worked, then we would have problems with the other elements within that parent element.
Motivation
With the new phone number format, phone numbers are written with spaces between them.
This means that when translating this number into rtl languages, their order gets mixed up:
Proposed Solution
Extend the do not translate function with the function that texts keep their direction: e.g. all texts that are marked as do not translate are always ltr
Alternatives
Add an extra button if the municipalities want to keep direction and keep the functionality seperate from do not translate (not recommended bcs it adds extra difficulty and possibilites of making mistakes)
User Story
As a user of the app I want to read the phone number in the correct order, even when using the app in rtl languages so that I always dial the correct number.
As a CMS user I want no extra work when using formatted phone numbers and translating content so that I can keep the time I need to work on Integreat as low as possible.
Additional Context
Mattermost Thread: https://chat.tuerantuer.org/digitalfabrik/pl/zu3x4bscy7bcfgen8p7fgngacc
@svenseeberg already tested the function and it seems to work, even between two rtl texts...
Design Requirements
None since it will be an invisible functionality.
The text was updated successfully, but these errors were encountered: