Code Climate has analyzed commit 60fa805 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 82.9%.

View more on Code Climate.

@MizukiTemma wouldn't using the slugify_ajax() method mean that the slug is only updated when saving the form (backend)?
Implementing this as a client functionality seems more elegant to me.
It also looks to me as if slugifyStr and slugify_ajax() are different in their functionality.

@theresantonie
slugify_ajax is callbed in the normal form by front-end events namely changes in the title field.
We can probably do the same for side-by-side view?

if (
    document.getElementById("id_title") &&
    (document.querySelector('[for="id_title"]') as HTMLElement)?.dataset?.slugifyUrl
) {
    document.getElementById("id_title").addEventListener("focusout", ({ target }) => {
        const currentTitle = (target as HTMLInputElement).value;
        const url = (document.querySelector('[for="id_title"]') as HTMLElement).dataset.slugifyUrl;
        slugify(url, { title: currentTitle }).then((response) => {
            /* on success write response to both slug field and permalink */
            slugField.value = response.unique_slug;
            updatePermalink(response.unique_slug);
        });
    });
}

@MizukiTemma If this works the same, it is probably better to use an existing function. 👍

@theresantonie slugify_ajax is callbed in the normal form by front-end events namely changes in the title field. We can probably do the same for side-by-side view?

if (
    document.getElementById("id_title") &&
    (document.querySelector('[for="id_title"]') as HTMLElement)?.dataset?.slugifyUrl
) {
    document.getElementById("id_title").addEventListener("focusout", ({ target }) => {
        const currentTitle = (target as HTMLInputElement).value;
        const url = (document.querySelector('[for="id_title"]') as HTMLElement).dataset.slugifyUrl;
        slugify(url, { title: currentTitle }).then((response) => {
            /* on success write response to both slug field and permalink */
            slugField.value = response.unique_slug;
            updatePermalink(response.unique_slug);
        });
    });
}

slugify_ajax is used in the page form and it uses page as a model_type. Should it target page as a model_type? Because I am getting error NoReverseMatch and slugifyUrl returning undefined when I am using it. 🤔

slugify_ajax is used in the page form and it uses page as a model_type. Should it target page as a model_type? Because I am getting error NoReverseMatch and slugifyUrl returning undefined when I am using it. 🤔

Yes, in page_sbs too :)