fix(p2p-upgrades): Rate-limit requests to list installers from other devices #811
gmaclennan
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Currently, discovery makes a
lookup()
request every 2 seconds, and when apeer
event is emitted, it will make aGET /installers
request to list the available installers. Theoretically this means that theGET /installers
request happens once every 2 seconds, but in testing it appears that thepeer
event can be emitted more frequently than every 2 seconds, perhaps because otherannounce()
events from other devices can also trigger apeer
event. This can result in a saturation ofGET /installers
requests.Fix: Rate-limit (throttle) requests to
GET /installers
by peer (e.g. requests to each peer should be throttled independently).Beta Was this translation helpful? Give feedback.
All reactions