Find nicer fix for utf-8-validate / bufferutil dep workaround #804
hackergrrl
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
291af8ae78bc952dd897e0a095cc553cbca364fd in mapeo-core adds the dependency
websocket-stream
, which depends onws
, which has dev dependenciesutf-8-validate
andbufferutil
. However,ws
hasrequire()
calls for these deps in its main code, wrapped in try/catch statements, which noderify doesn't seem to know to not include. This makes the backend build fail on mapeo-mobile.ws
folx don't seem to want to change this.For the time being, I've added
--filter
switches to thenoderify
call inscripts/build-backend.sh
to ignore these two modules, but it's only a stopgap, since we may one day depend on a module which in turn depends on one of these for legitimate purposes.Beta Was this translation helpful? Give feedback.
All reactions