Skip to content

feat: muD fast calculation for values <0.5 and >6 #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #145
yucongalicechen opened this issue Feb 7, 2025 · 1 comment · Fixed by #170
Closed
Tracked by #145

feat: muD fast calculation for values <0.5 and >6 #167

yucongalicechen opened this issue Feb 7, 2025 · 1 comment · Fixed by #170
Milestone
0.2.1 pre-release

Comments

@yucongalicechen
Copy link
Collaborator

yucongalicechen commented Feb 7, 2025 •
edited
Loading

Problem

Proposed solution

  1. Include muD up to 7 for fast calculation.
  2. Default to brute-force computation when muD < 0.5 or > 7; report muD value during computation.
@yucongalicechen yucongalicechen added this to the 0.2.1 release milestone Feb 7, 2025
@sbillinge
Copy link
Contributor

why are we going from 6 to 7? This seems pretty arbitrary. I think it is more a philosophical issue about how to handle this flow. We can define mud_threshold for example. Right now mud_threshold = 6. We could change mud_threshold to something else, but the conversation here might be better to be about what flow we want whenmud_threshold is exceeded in general.

@yucongalicechen yucongalicechen mentioned this issue Feb 23, 2025
Closed
23 tasks
@yucongalicechen yucongalicechen mentioned this issue Apr 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.1 pre-release
Development

Successfully merging a pull request may close this issue.

feat: increase fast cal to muD=7 yucongalicechen/diffpy.labpdfproc
2 participants
@sbillinge @yucongalicechen