Skip to content

feat: muD fast calculation for values <0.5 and >6 #167

New issue
New issue
Closed
Parent:muD as a required input
Listed in
#145
#170
Closed
feat: muD fast calculation for values <0.5 and >6#167
Parent:#165
Listed in
#145
#170
Milestone
 
0.2.1 pre-release
@yucongalicechen

Description

@yucongalicechen
yucongalicechen
opened on Feb 7, 2025 · edited by yucongalicechen
Collaborator

Problem

Proposed solution

  1. Include muD up to 7 for fast calculation.
  2. Default to brute-force computation when muD < 0.5 or > 7; report muD value during computation.

Activity

yucongalicechen
added a parent issue on Feb 7, 2025
yucongalicechen
added this to the 0.2.1 release milestone on Feb 7, 2025
sbillinge

sbillinge commented on Feb 7, 2025

@sbillinge
sbillinge
on Feb 7, 2025
Contributor

why are we going from 6 to 7? This seems pretty arbitrary. I think it is more a philosophical issue about how to handle this flow. We can define mud_threshold for example. Right now mud_threshold = 6. We could change mud_threshold to something else, but the conversation here might be better to be about what flow we want whenmud_threshold is exceeded in general.

yucongalicechen
mentioned this on Feb 23, 2025
yucongalicechen
mentioned this on Apr 15, 2025
sbillinge
closed this as completedin #170on Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    Development

    Participants

    @sbillinge@yucongalicechen

    Issue actions
      feat: muD fast calculation for values <0.5 and >6 · Issue #167 · diffpy/diffpy.labpdfproc