[rewrite] fix JavaLangAPIs #2804 (#2810)

Vincent Potucek · Vincent Potucek · commit ee6b28d3a740 · 2026-01-11T07:49:54.000+01:00
diff --git a/.github/workflows/changelog-print.yml b/.github/workflows/changelog-print.yml
@@ -14,6 +14,6 @@ jobs:
         with:
           java-version: 21
           distribution: 'temurin'
-      - name: Setup Gradle 🐘
+      - name: gradle caching
         uses: gradle/actions/setup-gradle@v5
       - run: ./gradlew changelogPrint
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -7,6 +7,7 @@ on:
   push:
     branches: [main, release]
   workflow_dispatch:
+
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
@@ -18,35 +19,34 @@ jobs:
       buildcacheuser: ${{ secrets.BUILDCACHE_USER }}
       buildcachepass: ${{ secrets.BUILDCACHE_PASS }}
     steps:
-      - name: Checkout Code 📥
+      - name: Checkout
         uses: actions/checkout@v6
         with:
           fetch-depth: 0
       - uses: actions/setup-java@v5
         with:
-          distribution: temurin
+          distribution: "temurin"
           java-version: 21
-      - name: Setup Gradle 🐘
+      - name: gradle caching
         uses: gradle/actions/setup-gradle@v5
       - name: Spotless ✨
-        run: ./gradlew clean spotlessCheck
-      - name: Error Prone 🚧
-        run: ./gradlew clean assemble
-      - name: Test Classes ⚙️
-        run: ./gradlew clean testClasses
+        run: ./gradlew spotlessCheck
       - name: Rewrite ♻️
-        run: ./gradlew clean rewriteDryRun
+        run: ./gradlew rewriteDryRun
+      - name: assemble testClasses
+        run: ./gradlew assemble testClasses
   build:
-    name: Build 🏗️
     needs: sanity-check
     strategy:
       fail-fast: false
       matrix:
         kind: [maven, gradle]
-        jre: [17, 21, 24] # test on the latest Java version once Gradle & Maven support it.
+        # Test on the latest Java version once Gradle & Maven support it.
+        jre: [17, 21, 24]
         os: [ubuntu-latest, windows-latest]
         include:
-          - kind: npm # npm on linux only (crazy slow on windows).
+          # npm on linux only (crazy slow on windows)
+          - kind: npm
             jre: 17
             os: ubuntu-latest
           - kind: shfmt
@@ -58,64 +58,66 @@ jobs:
             os: ubuntu-latest
     runs-on: ${{ matrix.os }}
     steps:
-      - name: Checkout Code 📥
+      - name: Checkout
         uses: actions/checkout@v6
       - uses: actions/setup-java@v5
         with:
-          distribution: temurin
+          distribution: "temurin"
           java-version: ${{ matrix.jre }}
-      - name: Setup Gradle 🐘
+      - name: gradle caching
         uses: gradle/actions/setup-gradle@v5
-      - name: Build Maven 🪶
+      - name: build (maven-only)
         if: matrix.kind == 'maven'
-        run: ./gradlew :plugin-maven:build -x spotlessCheck
-      - name: Build Gradle 🐘
+        run: ./gradlew :plugin-maven:build -x spotlessCheck -x rewriteDryRun
+      - name: build (everything-but-maven)
         if: matrix.kind == 'gradle'
-        run: ./gradlew build -PSPOTLESS_EXCLUDE_MAVEN=true -x spotlessCheck
-      - name: Test npm 📊
+        run: ./gradlew build -x spotlessCheck -x rewriteDryRun -PSPOTLESS_EXCLUDE_MAVEN=true
+      - name: test npm
         if: matrix.kind == 'npm'
         run: ./gradlew testNpm
-      - name: Setup Go
+      - name: Setup go
         if: matrix.kind == 'shfmt'
         uses: actions/setup-go@v6
         with:
-          go-version: stable
-      - name: Install shfmt 📥
+          go-version: 'stable'
+      - name: Install shfmt
         if: matrix.kind == 'shfmt'
-        run: go install mvdan.cc/sh/v3/cmd/shfmt@${{ matrix.shfmt-version }}
-      - name: Test shfmt 📊
+        run: |
+          go install mvdan.cc/sh/v3/cmd/shfmt@${{ matrix.shfmt-version }}
+      - name: Test shfmt
         if: matrix.kind == 'shfmt'
         run: ./gradlew testShfmt
-      - name: Test IDEA 📊
+      - name: Test idea
         if: matrix.kind == 'idea'
         run: |
           download_link=$(curl https://data.services.jetbrains.com/products/releases\?code\=IIC\&latest\=true\&type\=release | jq -r '.IIC[0].downloads.linux.link')
-          curl --location $download_link -o idea.tar.gz
+          curl --location "$download_link" -o idea.tar.gz
           tar -xf idea.tar.gz
           cd idea-IC*
           export PATH=${PATH}:$(pwd)/bin
           cd ..
           ./gradlew testIdea
-      - name: Junit Report 📋
+      - name: junit result
         uses: mikepenz/action-junit-report@v6
-        if: always() # always run even if the previous step fails.
+        if: always() # always run even if the previous step fails
         with:
           check_name: JUnit ${{ matrix.kind }} ${{ matrix.jre }} ${{ matrix.os }}
           report_paths: '*/build/test-results/*/TEST-*.xml'
           check_retries: true
-  complete: # this check is required in branch protection rules.
-    name: Complete ✅
+
+  # Status check that is required in branch protection rules.
+  final-status:
     needs:
       - sanity-check
       - build
     runs-on: ubuntu-latest
     if: always()
     steps:
-      - name: Check 🦉
+      - name: Check
         run: |
           results=$(tr -d '\n' <<< '${{ toJSON(needs.*.result) }}')
-          if ! grep -q -v -E '(failure|cancelled)' <<< $results; then
-            echo ❌ One or more required jobs failed.
+          if ! grep -q -v -E '(failure|cancelled)' <<< "$results"; then
+            echo "One or more required jobs failed"
             exit 1
           fi
-          echo ✅ All required jobs completed successfully.
+          echo "All required jobs completed successfully."
diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
@@ -36,7 +36,7 @@ jobs:
         # https://docs.github.com/en/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#overriding-automatic-language-detection
 
     steps:
-    - name: Checkout Code 📥
+    - name: Checkout repository
       uses: actions/checkout@v6
       with:
         # We must fetch at least the immediate parents so that if this is
@@ -54,7 +54,7 @@ jobs:
       with:
         languages: ${{ matrix.language }}
         # If you wish to specify custom queries, you can do so here or in a config file.
-        # By default, queries listed here will override any specified in a config file.
+        # By default, queries listed here will override any specified in a config file. 
         # Prefix the list here with "+" to use these queries and those in the config file.
         # queries: ./path/to/local/query, your-org/your-repo/queries@main
 
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -42,7 +42,7 @@ jobs:
         with:
           java-version: 21
           distribution: 'temurin'
-      - name: Setup Gradle 🐘
+      - name: gradle caching
         uses: gradle/actions/setup-gradle@v5
       - name: git fetch origin main
         run: git fetch origin main
diff --git a/README.md b/README.md
@@ -8,7 +8,7 @@ Spotless can format &lt;antlr | c | c# | c++ | css | flow | graphql | groovy | h
 
 You probably want one of the links below:
 
-## [✨️ Spotless for Gradle](plugin-gradle) (with integrations for [VS Code](https://marketplace.visualstudio.com/items?itemName=richardwillis.vscode-spotless-gradle) and [IntelliJ](https://plugins.jetbrains.com/plugin/18321-spotless-gradle))
+## [❇️ Spotless for Gradle](plugin-gradle) (with integrations for [VS Code](https://marketplace.visualstudio.com/items?itemName=richardwillis.vscode-spotless-gradle) and [IntelliJ](https://plugins.jetbrains.com/plugin/18321-spotless-gradle))
 
 ```console
 user@machine repo % ./gradlew build
@@ -25,7 +25,7 @@ user@machine repo % ./gradlew build
 BUILD SUCCESSFUL
 ```
 
-## [✨️ Spotless for Maven](plugin-maven)
+## [❇️ Spotless for Maven](plugin-maven)
 
 ```console
 user@machine repo % mvn spotless:check
@@ -40,7 +40,7 @@ user@machine repo % mvn spotless:check
 [INFO] BUILD SUCCESS
 ```
 
-## [✨️ Spotless for SBT (external for now)](https://github.com/moznion/sbt-spotless)
+## [❇️ Spotless for SBT (external for now)](https://github.com/moznion/sbt-spotless)
 ## [Other build systems](CONTRIBUTING.md#how-to-add-a-new-plugin-for-a-build-system)
 
 ## How it works (for potential contributors)
diff --git a/rewrite.yml b/rewrite.yml
@@ -7,14 +7,9 @@ recipeList:
   - org.openrewrite.gradle.EnableGradleBuildCache
   - org.openrewrite.gradle.EnableGradleParallelExecution
   - org.openrewrite.gradle.GradleBestPractices
-  - org.openrewrite.hcl.format.RemoveTrailingWhitespace
   - org.openrewrite.java.RemoveUnusedImports
-  - org.openrewrite.java.ShortenFullyQualifiedTypeReferences
-  - org.openrewrite.java.SimplifySingleElementAnnotation
-  - org.openrewrite.java.format.EmptyNewlineAtEndOfFile
   - org.openrewrite.java.format.NormalizeFormat
   - org.openrewrite.java.format.NormalizeLineBreaks
-  - org.openrewrite.java.format.PadEmptyForLoopComponents
   - org.openrewrite.java.format.RemoveTrailingWhitespace
   - org.openrewrite.java.migrate.UpgradeToJava17
   - org.openrewrite.java.migrate.lang.JavaLangAPIs
@@ -27,32 +22,19 @@ recipeList:
   - org.openrewrite.java.recipes.RecipeTestingBestPractices
   - org.openrewrite.java.security.JavaSecurityBestPractices
   - org.openrewrite.staticanalysis.BufferedWriterCreationRecipes
-  - org.openrewrite.staticanalysis.ChainStringBuilderAppendCalls
   - org.openrewrite.staticanalysis.CommonStaticAnalysis
-  - org.openrewrite.staticanalysis.CustomImportOrder
-  - org.openrewrite.staticanalysis.DefaultComesLast
-  - org.openrewrite.staticanalysis.EmptyBlock
   - org.openrewrite.staticanalysis.EqualsAvoidsNull
-  - org.openrewrite.staticanalysis.ExplicitInitialization
-  - org.openrewrite.staticanalysis.FallThrough
-  - org.openrewrite.staticanalysis.FinalizePrivateFields
-  - org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators
-  - org.openrewrite.staticanalysis.HideUtilityClassConstructor
   - org.openrewrite.staticanalysis.JavaApiBestPractices
   - org.openrewrite.staticanalysis.LowercasePackage
   - org.openrewrite.staticanalysis.MissingOverrideAnnotation
   - org.openrewrite.staticanalysis.ModifierOrder
-  - org.openrewrite.staticanalysis.NeedBraces
   - org.openrewrite.staticanalysis.NoFinalizer
   - org.openrewrite.staticanalysis.NoToStringOnStringType
   - org.openrewrite.staticanalysis.NoValueOfOnStringType
   - org.openrewrite.staticanalysis.RemoveUnusedLocalVariables
   - org.openrewrite.staticanalysis.RemoveUnusedPrivateFields
   - org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods
-  - org.openrewrite.staticanalysis.ReplaceStringBuilderWithString
-  - org.openrewrite.staticanalysis.ReplaceThreadRunWithThreadStart
   - org.openrewrite.staticanalysis.SimplifyTernaryRecipes
-  - org.openrewrite.staticanalysis.TypecastParenPad
   - org.openrewrite.staticanalysis.URLEqualsHashCodeRecipes
   - org.openrewrite.staticanalysis.UnnecessaryCloseInTryWithResources
   - org.openrewrite.staticanalysis.UnnecessaryExplicitTypeArguments
diff --git a/testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java b/testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java
@@ -0,0 +1,53 @@
+/*
+ * Copyright 2016-2025 DiffPlug
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.diffplug.spotless;
+
+import java.lang.reflect.Method;
+import java.lang.reflect.Modifier;
+import java.lang.reflect.Parameter;
+import java.util.Arrays;
+import java.util.Iterator;
+
+/**
+ * Utilities for dumping class info, helpful for
+ * debugging reflection code.  Probably easiest to
+ * just copy-paste these methods where you need
+ * them.
+ */
+public class ReflectionUtil {
+	public static void dumpAllInfo(String name, Object obj) {
+		System.out.println(name + " of type " + obj.getClass());
+		for (Method method : obj.getClass().getMethods()) {
+			dumpMethod(method);
+		}
+	}
+
+	public static void dumpMethod(Method method) {
+		System.out.print(Modifier.toString(method.getModifiers()));
+		System.out.print(" " + method.getReturnType());
+		System.out.print(" " + method.getName() + "(");
+		Iterator<Parameter> paramIter = Arrays.asList(method.getParameters()).iterator();
+		while (paramIter.hasNext()) {
+			Parameter param = paramIter.next();
+
+			System.out.print(param.getType().getName());
+			if (paramIter.hasNext()) {
+				System.out.print(", ");
+			}
+		}
+		System.out.println(")");
+	}
+}
diff --git a/testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java b/testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java
diff --git a/testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java b/testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java
