Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's wrong with it? #3

Open
dameer opened this issue Sep 17, 2018 · 3 comments
Open

What's wrong with it? #3

dameer opened this issue Sep 17, 2018 · 3 comments

Comments

@dameer
Copy link

dameer commented Sep 17, 2018

HTML structure:

...
<div class="site-offset">
    <a href="#" id="k-flux" smooth-parallax="" container=".site-offset" start-movement="0.05">FLUX</a>
    <div id="content" class="content">
    ...
    </div>
</div>
...

Init as required:

<script type="text/javascript">
  window.addEventListener("load", function () {
    SmoothParallax.init();
  });
</script>

If well understood the point, #k-flux should move within ".site-offset". No error, warning or whatsoever. It just doesn't work.

@diegoversiani
Copy link
Owner

Hi Damer,

There is one missing required attribute on your element:

Configure elements movement
You'll also have to set at least one more attribute start-position or end-position, see options at standard options.

Please check again de sections Basic Usage and Standard Options.

Sorry for the documentation is not as good as we'd like, I added a task to my personal to-do list to fix it.

Best!

@dameer
Copy link
Author

dameer commented Sep 18, 2018

Yeah, got it workin now. It was because I kinda thought that if no position is set, the plugin will pick up defaults. Overlooked required config tho.
Thanks for your work mate, I like the plugin!

@diegoversiani
Copy link
Owner

That's good :)

I would expect it too, I think when I made it my needs where a bit different and having the required config made sense.

I'll keep this issue open until I fix the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants