-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue Report]: No more Diablo Speech when entering DLVL 16 first time #7451
Comments
Very strange, the commit in question that supposedly broke it was verified to be working correctly before being merged. There have been some changes with sound logic (tsv file and such). Are you sure it's not rooted in one of those changes? I'll take a look and see later if I can find the root cause of the problem. |
EDIT: Since this is meant for MP games where Diablo was killed by another player, you have to make sure to check the Lines 2987 to 2988 in 63fd721
|
Thank you! I'll submit a PR for this. |
Fixed by : #7467 as a part of the cleanup |
Operating System
Linux x64
DevilutionX version
Custom build (commit 1078598)
Describe
Since commit ad452cb there is no more Diablo Speech when entering DLVL 16 first time.
To Reproduce
Check the commit before and listen to Diablo when you enter the pentagram.
Use the attached save game.
speech.zip
You should hear Diablo speaking. But since commit ad452cb
you can't hear Diablo speak anymore.
The commit before the issue is 6b2a0c4
Expected Behavior
Hear Diablo speak when you first enter level 16
Additional context
If I understand correctly, the missing audio message was activated in the following commit.
2881f13
The text was updated successfully, but these errors were encountered: