-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Leafsnap to ONNX model zoo. #370
Comments
To contribute a model to the ONNX model zoo one should follow the How to contribute instructions. |
Started composing the LeafSnap30 contribution |
Internal reviews could happen in another branch, namely leafsnap |
Our ONNX model (as published on Zenodo) has been verified against the latest onnx (v.1.12.0) checker. |
First internal PR submitted. Asked @cwmeijer for review. Only parts of the README have been filled! |
Great text! Approved! I'm not so happy about this issue containing a long list of check boxes. It now is unclear what part is completely done and what part still needs a review. Of course I can see that in your PR, but still, it would be nicer to split some of it into separate tasks so they can end up in the Done column on the kanban board. |
This comment was marked as outdated.
This comment was marked as outdated.
The PR has problems due to unsigned commits! 👎 |
@loostrum I wonder if you can do something about your commits if it's in a fork of my repo... |
I need some help with this one. When trying to git clone the onnx model repo (even only my branch) locally I get lfs issues, which I can't solve in order to proceed. I've worked exclusively on github on it and Leon did some local commits . But the ONNX repo complains the commits are not signed. See onnx/models#567 (review) for the PR review and pointers to the solution isntructions. @stefsmeets would you be able to help me with the signing off the commits problem? Does it have to be live as it's my repo or you can actually do it? |
What is the problem with signing the commits? Did you follow the instructions here? |
I tried, but I couldn't apply them as cloning the repo gives me errors, so I cannot continue with the instructions. |
Replacing issue #368.
The submission should contain the following sections:
Description
text
ONNX checker
Model #390
Inference #391
Model creation #392
Test Data Creation #393
References
Contributors
License
The text was updated successfully, but these errors were encountered: