Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Leafsnap to ONNX model zoo. #370

Closed
8 tasks done
elboyran opened this issue Oct 18, 2022 · 15 comments
Closed
8 tasks done

Add Leafsnap to ONNX model zoo. #370

elboyran opened this issue Oct 18, 2022 · 15 comments
Assignees
Labels
must have outreach advertising beyond publication label

Comments

@elboyran
Copy link
Contributor

elboyran commented Oct 18, 2022

Replacing issue #368.

The submission should contain the following sections:

@elboyran elboyran added must have outreach advertising beyond publication label labels Oct 18, 2022
@elboyran elboyran self-assigned this Oct 18, 2022
@elboyran
Copy link
Contributor Author

To contribute a model to the ONNX model zoo one should follow the How to contribute instructions.

@elboyran
Copy link
Contributor Author

Started composing the LeafSnap30 contribution

@elboyran
Copy link
Contributor Author

elboyran commented Nov 4, 2022

Internal reviews could happen in another branch, namely leafsnap

@elboyran
Copy link
Contributor Author

elboyran commented Nov 8, 2022

Our ONNX model (as published on Zenodo) has been verified against the latest onnx (v.1.12.0) checker.

@elboyran
Copy link
Contributor Author

elboyran commented Nov 8, 2022

First internal PR submitted. Asked @cwmeijer for review. Only parts of the README have been filled!

@cwmeijer
Copy link
Member

cwmeijer commented Nov 9, 2022

Great text! Approved!

I'm not so happy about this issue containing a long list of check boxes. It now is unclear what part is completely done and what part still needs a review. Of course I can see that in your PR, but still, it would be nicer to split some of it into separate tasks so they can end up in the Done column on the kanban board.

@elboyran
Copy link
Contributor Author

elboyran commented Nov 22, 2022

Added some References, see the PR. I suggested @cwmeijer as reviewer.

@elboyran

This comment was marked as outdated.

@elboyran elboyran removed the blocked label Jan 17, 2023
@elboyran
Copy link
Contributor Author

elboyran commented Jan 17, 2023

The PR has problems due to unsigned commits! 👎
Will try fixing it by Checkout with GitHib CLI
image

@elboyran
Copy link
Contributor Author

@loostrum I wonder if you can do something about your commits if it's in a fork of my repo...

@elboyran
Copy link
Contributor Author

Make it ready for review as all commits have the
image
label. I have left this info in a comment. Lets see what the ONNX people say.

@elboyran
Copy link
Contributor Author

elboyran commented Mar 21, 2023

I need some help with this one. When trying to git clone the onnx model repo (even only my branch) locally I get lfs issues, which I can't solve in order to proceed. I've worked exclusively on github on it and Leon did some local commits .

But the ONNX repo complains the commits are not signed. See onnx/models#567 (review) for the PR review and pointers to the solution isntructions.

@stefsmeets would you be able to help me with the signing off the commits problem? Does it have to be live as it's my repo or you can actually do it?

@elboyran
Copy link
Contributor Author

Not sure it helps, but here are the lfs errors:

lfs

@stefsmeets
Copy link
Contributor

What is the problem with signing the commits? Did you follow the instructions here?

@elboyran
Copy link
Contributor Author

I tried, but I couldn't apply them as cloning the repo gives me errors, so I cannot continue with the instructions.

@stefsmeets stefsmeets removed their assignment Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
must have outreach advertising beyond publication label
Projects
None yet
Development

No branches or pull requests

3 participants