Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline scripts edit in external editor are not refreshed even after close and reopen #2245

Open
hsandt opened this issue May 21, 2024 · 0 comments
Labels
Bug 🐞 Something isn't working Enhance ⚡ Improve a feature's workflow.

Comments

@hsandt
Copy link

hsandt commented May 21, 2024

The problem

Describe the bug
This is basically #935 from Dialogic 1, except instead of .json, we have the issue with the new plain text format.

I am editing my timeline scripts in some external editor, but there is no way to reload it in Godot.

Closing and reopening the resource in the Dialogic panel still shows the old content. Then, modifying and saving any change in Godot will overwrite the external changes without warning as described in the old json issue.

Unfortunately this is a known issue with Godot itself relying too much on old cache: godotengine/godot#30302

However, even if Dialogic is unable to fix this core part of Godot, maybe it could at least add some button to force reload new content - or have some routine to detect file change and force refresh content displayed in the Dialogic panel?

To Reproduce
Steps to reproduce the behavior:

  1. Create a timeline and add some text
  2. Right-click on timeline > Open in External Program (some text/code editor)
  3. Modify or add new lines. Save in external editor
  4. Switch back to Godot: no change
  5. Close (middle-click) and reopen timeline (double-click on it in FileSystem)
  6. Modify on Godot side and save
  7. Back to external editor: changes were overwritten

Expected behavior
External editor should be able to apply changes that Godot would reload, or at least a button would allow manual reload. Close and reopen should also force reload.

Screenshots
N/A but can provide video if needed

System (please complete the following information):

  • OS: Linux Ubuntu 22.04
    Godot Version: v4.2.1.stable.official [b09f793f5]
    Dialogic Version: main branch, commit 2858c4e (2024-05-15)

Solutions

Workaround

I'd have to close and reopen Godot completely as usually with resources edited externally, but that's cumbersome.

However, at least it allows a writer to do most of the job when Godot is closed, then run Godot and only fix small issues directly in the Dialogic Panel.

Possible fixes

@Jowan-Spooner Jowan-Spooner added Bug 🐞 Something isn't working Enhance ⚡ Improve a feature's workflow. labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working Enhance ⚡ Improve a feature's workflow.
Projects
None yet
Development

No branches or pull requests

2 participants