-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many Dialogic errors such as "Parse Error: Could not resolve class" and "Invalid call. Nonexistent function" on editor start, Dialogic panel Character selection and edit #2225
Comments
I got a more consistent repro during project edit, not on start, with similar but a slightly different set of errors: Open Dialogic panel and select character:
Edit Display Name and try to save:
It is possible that one of the errors prevent immediate character saving, therefore causing #2227 |
Very weird. When adding a new character portrait (the entry, not the picture), I got a similar issue:
and noticed that field_vector2.gd defines a %PortraitOffset._set_value(data.get('offset', Vector2())) to: %PortraitOffset.set_value(data.get('offset', Vector2())) but then I got:
which I don't understand at all. |
Before, I also had an error in
But this one was easy to avoid, just checking for null: func add_portrait_item(portrait_name: String, portrait_data: Dictionary, parent_item: TreeItem, previous_name := "") -> TreeItem:
var item: TreeItem = %PortraitTree.create_item(parent_item)
item.set_text(0, portrait_name)
item.set_metadata(0, portrait_data)
if previous_name.is_empty():
item.set_meta('previous_name', get_full_item_name(item))
else:
item.set_meta('previous_name', previous_name)
# LOCAL FIX by hsandt: check for null current_resource
# This avoids errors:
# res://addons/dialogic/Editor/CharacterEditor/character_editor_portrait_tree.gd:32 - Invalid get index 'default_portrait' (on base: 'Nil').
# res://addons/dialogic/Editor/CharacterEditor/character_editor.gd:345 - Cannot call method 'set_meta' on a null value.
if editor.current_resource:
if portrait_name == editor.current_resource.default_portrait:
item.add_button(0, get_theme_icon('Favorites', 'EditorIcons'), 2, true, 'Default')
return item |
And another error I don't understand at all, when refreshing the portrait image field: print("current_portrait_data: ", current_portrait_data)
var mirror: bool = current_portrait_data.get('mirror', false) != current_resource.mirror
I debug printed the Despite all these For now I'll just ignore further tool errors and focus on actual runtime. |
Unfortunately, still many errors left and I'm not sure how to fix them, see dialogic-godot/dialogic#2225
The problem
Describe the bug
I get many errors each time I open the Godot editor:
I suspect that Godot is responsible for this as it doesn't parse things in order (I saw some issues on Godot repo although not sure which specific one it would be). If so there is not much choice to fix it from plugin side, unless you know a workaround.
Note that the game runs fine at runtime. It's just a one-time issue that doesn't prevent development.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Start without errors
Screenshots
If applicable, add screenshots to help explain your problem.
System (please complete the following information):
Solutions
Workaround
No workaround known
Possible fixes
It may be on Godot side... but it would be nice to find out what specifically triggers this, as not all plugins cause such errors
The text was updated successfully, but these errors were encountered: