Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert "fix: select-field not showing in correct place" #1614

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

kabaros
Copy link
Collaborator

@kabaros kabaros commented Sep 30, 2024

This reverts commit 7d27d71. PR #1400 as it seems to have caused this issue: https://dhis2.atlassian.net/browse/DHIS2-18119

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Sep 30, 2024

🚀 Deployed on https://pr-1614--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify September 30, 2024 16:28 Inactive
@kabaros kabaros changed the title fix: Revert "fix: select-field not showing in correct place" fix: revert "fix: select-field not showing in correct place" Sep 30, 2024
@kabaros kabaros force-pushed the revert/select-wrapper-change branch from ae4f556 to e2eaf2a Compare September 30, 2024 16:33
@kabaros kabaros marked this pull request as ready for review September 30, 2024 16:34
@kabaros kabaros requested a review from a team as a code owner September 30, 2024 16:34
@dhis2-bot dhis2-bot temporarily deployed to netlify September 30, 2024 16:37 Inactive
Copy link
Member

@tomzemp tomzemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. I checked locally, and it fixed the problem:

image

@kabaros kabaros merged commit c83de6b into master Oct 1, 2024
16 checks passed
@kabaros kabaros deleted the revert/select-wrapper-change branch October 1, 2024 08:59
dhis2-bot added a commit that referenced this pull request Oct 1, 2024
## [9.11.7](v9.11.6...v9.11.7) (2024-10-01)

### Bug Fixes

* revert "fix: select-field not showing in correct place" ([#1614](#1614)) ([c83de6b](c83de6b))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 9.11.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

dhis2-bot added a commit that referenced this pull request Nov 14, 2024
# [10.0.0-alpha.7](v10.0.0-alpha.6...v10.0.0-alpha.7) (2024-11-14)

### Bug Fixes

* **sharing-dialog:** add 'route' to SharingType type ([#1617](#1617)) ([1d9664a](1d9664a))
* revert "fix: select-field not showing in correct place" ([#1614](#1614)) ([c83de6b](c83de6b))
* **translations:** sync translations from transifex (master) ([491bf04](491bf04))
* update default props to JS default params ([#1598](#1598)) ([20e343f](20e343f))

### Features

* merge branch master into branch ([0577074](0577074))
* **icons:** add link-off icons ([e72be1e](e72be1e))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 10.0.0-alpha.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants