fix(pagination): add row padding on small screens and demo stories #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mohammer5
approved these changes
Sep 14, 2023
|
🚀 Deployed on https://pr-1405--dhis2-ui.netlify.app |
Passing run #3031 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
KaiVandivier
approved these changes
Sep 14, 2023
HendrikThePendric
deleted the
DHIS2-15465-pagination-row-padding-in-narrow-containers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to DHIS2-15465
Description
This is a very unobtrusive PR that only adds a
row-gapCSS rule to the pagination container to prevent the button "rows" touching when the pagination container is narrow. Implementation was discussed with Joe.Checklist
NB: API docs and tests weren't relevant for this PR.
Screenshots
BEFORE
AFTER
