fix: display correct app version in dhis2 and updated workflows #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenniferarnesen
changed the title
jenniferarnesen
changed the title
|
🚀 Deployed on https://pr-3061--dhis2-dashboard.netlify.app |
edoardo
approved these changes
Aug 23, 2024
jenniferarnesen
changed the title
jenniferarnesen
added
the
e2e record
dashboards-app
|
|||||||||||||||||||||||||||||||||||||||||||
| Project |
dashboards-app
|
| Branch Review |
chore/new-gh-workflows
|
| Run status |
|
| Run duration | 05m 17s |
| Commit |
|
| Committer | Jen Jones Arnesen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
3
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
3
|
Passing
|
8
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
dashboard_filter.feature • 2 failed tests • e2e-chrome-parallel-2.40-1
| Test | Artifacts | |
|---|---|---|
| Dashboard filter > I add a Organisation unit filter |
Test Replay
Screenshots
Video
|
|
| Dashboard filter > I add a Facility Type filter |
Test Replay
Screenshots
Video
|
|
view_errors.feature • 1 failed test • e2e-chrome-parallel-2.40-1
| Test | Artifacts | |
|---|---|---|
| Errors while in view mode > Starring a dashboard fails |
Test Replay
Screenshots
Video
|
|
dhis2-bot
added a commit
that referenced
this pull request
Aug 26, 2024
## [100.2.4](v100.2.3...v100.2.4) (2024-08-26) ### Bug Fixes * add missing dependencies for semantic-release ([#3062](#3062)) ([9fe6ae5](9fe6ae5)) * display correct app version in dhis2 and updated workflows ([#3061](#3061)) ([69b8425](69b8425)) * stop fetching schemas and replace d2 with dataEngine ([#3056](#3056)) ([49428c6](49428c6))
|
🎉 This PR is included in version 100.2.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I set this to a fix, because after this is released, user will see the correct app version in dhis2.
PR workflow: verify-pr.yml
This workflow triggers on pull request actions only. It verifies that the PR code passes build, lint, test, and e2e.
Release workflow: release.yml
This workflow only runs on pushes to the master branch since this is the only release branch. Every release involves 2 commits to master:
The release workflow triggers for both pushes to master listed above. But we only want the the release job to run for the first push.
The semantic-release workflow steps are found in .releaserc. Previously @dhis2/action-semantic-release was used but this was overkill for our needs and difficult to make changes to. Therefore, we created our own semantic-release steps in .releaserc:
After semantic-release is complete, the bundle is then published to AppHub so that it is actually available to all users. Because of the addition of the exec yarn build step, all references to the version in the bundle should be the same, thus fixing the annoying bug where the old version displays in the instance after installing the later version.
If any point in the release fails, then a failure message is sent to slack. If the release step succeeds, then a success message is posted to slack that includes the new version number and the release notes.
Publish to d2-ci: publish-to-d2-ci.yml
This workflow publishes the build to d2-ci in the following cases:
The [skip release] commit on master