Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear only required build dirs #894

Merged
merged 3 commits into from
Nov 21, 2024
Merged

fix: clear only required build dirs #894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
572530b
fix: only clear required build output directories
amcgee Nov 21, 2024
1b31c2b
chore: update yarn.lock
amcgee Nov 21, 2024
6efd244
chore: remove unused lib bundle output paths
amcgee Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cli/src/commands/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,6 @@ const handler = async ({
? getAppParameters(standalone, config)
: null

await fs.remove(paths.buildOutput)

await exitOnCatch(
async () => {
if (
Expand Down Expand Up @@ -196,6 +194,7 @@ const handler = async ({
process.exit(1)
}

await fs.remove(paths.buildAppOutput)
await fs.copy(paths.shellBuildOutput, paths.buildAppOutput)

if (packAppOutput) {
Expand Down
2 changes: 0 additions & 2 deletions cli/src/lib/paths.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,6 @@ module.exports = (cwd = process.cwd(), { typeScript } = {}) => {
'bundle',
'{name}-{version}.zip'
),
buildLibBundleFile: '{name}-{version}.zip',
buildLibBundleOutput: path.join(base),

launchPath: 'index.html',
pluginLaunchPath: 'plugin.html',
Expand Down
Loading
Loading