Skip to content

Commit 4178b36

Browse files
committed
docs: small revisions in react 18 section
1 parent 271e359 commit 4178b36

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

docs/migration/v12.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ Check out the [script docs](../scripts/migrate/js-to-jsx.md) for options, tips,
7979

8080
## React 18
8181

82-
With this update we also upgraded from React 16 to React 18. Upgrading to `@dhis2/cli-app-scripts` version 12 should generally a smooth process for the consuming apps. Most of the [changes](https://react.dev/blog/2022/03/08/react-18-upgrade-guide) shouldn't affect most apps.
82+
With this update, we also upgraded from React 16 to React 18. Upgrading to `@dhis2/cli-app-scripts` version 12 should generally a smooth process for the consuming apps. Most of the [changes](https://react.dev/blog/2022/03/08/react-18-upgrade-guide) shouldn't affect most apps.
8383

8484
### Default props
8585

@@ -289,7 +289,7 @@ describe('<Comment />', () => {
289289
Enzyme is [considered dead](https://dev.to/wojtekmaj/enzyme-is-dead-now-what-ekl): there is no official adapter for React 18 (or 17), so it's best to [migrate to React Testing Library](https://testing-library.com/docs/react-testing-library/migrate-from-enzyme/) for tests, if possible.
290290

291291
:::tip
292-
If it's not currently possible to migrate, there is an [unofficial React 18 adapter](https://github.com/cfaester/enzyme-adapter-react-18) that can help in the mean time. However, it is highly recommended this is a temporary solution and you should still schedule migrating away from Enzyme.
292+
If it's not currently possible to migrate, there is an [unofficial React 18 adapter](https://github.com/cfaester/enzyme-adapter-react-18) that can help in the mean time. However, this should be considered a temporary solution, and migrating away from Enzyme should be scheduled.
293293
:::
294294

295295
## Environment variables

0 commit comments

Comments
 (0)