Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIN function is undefined? #8

Open
changtj opened this issue Jun 7, 2018 · 4 comments
Open

MIN function is undefined? #8

changtj opened this issue Jun 7, 2018 · 4 comments

Comments

@changtj
Copy link

changtj commented Jun 7, 2018

visual studio 2017, stand libraries.
@dhess
Copy link
Owner

dhess commented Jun 7, 2018

Please see the README — Windows is not supported. However, I may accept a patch if it’s portable and/or clean.

@changtj
Copy link
Author

changtj commented Jun 7, 2018

@dhess oh, thanks, i use it on windows. thanks for you work.

@dhess
Copy link
Owner

dhess commented Jun 8, 2018

Do you have a fix for the MIN macro on Windows?

@changtj
Copy link
Author

changtj commented Jun 11, 2018

@dhess

i defined one macro.

#define MIN min( a, b) < 0 ? 0 : min( a, b)

the function is small, it is use to define.

jamiebullock pushed a commit to jamiebullock/c-ringbuf that referenced this issue Oct 3, 2018
Define MIN macro if undefined. Fixes dhess#8
c636fb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhess @changtj