fix: ensure resource policy matches the whole arn #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @G-Rath for PR |
cnuss
added a commit
to scaffoldly/serverless-offline
that referenced
this pull request
Jun 19, 2024
* master: fix: improve wildcard handling in authorizer policy resource parser (dherault#1797) fix: ensure resource policy matches the whole arn (dherault#1798)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the regexp used to test resource arns with wildcards so that they don't have an implicit wildcard at the end
Motivation and Context
Resolves #1191
How Has This Been Tested?
I have run the tests and used this locally
Screenshots (if appropriate):