fix: improve wildcard handling in authorizer policy resource parser #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnuss
added a commit
to scaffoldly/serverless-offline
that referenced
this pull request
Jun 19, 2024
* master: fix: improve wildcard handling in authorizer policy resource parser (dherault#1797) fix: ensure resource policy matches the whole arn (dherault#1798)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the parsing logic of resource arns in authorizer policies so that it handles wildcards more correctly
Motivation and Context
Currently
serverless-offlinewill crash if you use a resource arn that ends with a wildcard'd segment even though that is allowed per the docs:and here too:
Resolves #1794
How Has This Been Tested?
I ran the test suite and tried it out locally.
Screenshots (if appropriate):