-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: return 500 Internal Server Error on python error #1796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good PR, thanks for the solve. Do you want it in v13 (serverless v3) or v14 (serverless v4) or both?
Thanks! I'd love to see it go to both, as I'm currently still on serverless v3 with most projects. |
I'll see if I can squeeze that this week |
Sorry for the delay, I'll see that it is merged |
fix: return 500 Internal Server Error on python error
Sorry but I had to revert your PR because of failing test. Please open a new one if you want it merged. |
Description
Return a 500 Internal Server Error when the Python handler raises an error
Motivation and Context
When (Python) code raises an error, AWS Lambda returns a 500 with a generic JSON response.
With this change the behaviour of Serverless Offline is more inline with AWS Lambda.
How Has This Been Tested?
Added an automated test for Python.
Screenshots (if appropriate):