From 2bb21f94a5d2e20351edaccd98be811ada18e473 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Besson?= Date: Thu, 29 Jun 2023 11:27:05 +0100 Subject: [PATCH 1/2] Add deprecation flags for LegacyQTTools/LegacyQTReader/LegacyQTWriter These classes depended on the external QuickTime for Java library which is long obsolete. This commit marks them as deprecated in preparation for removal in the upcoming major release of Bio-Formats --- components/formats-bsd/src/loci/formats/gui/LegacyQTTools.java | 3 +++ components/formats-bsd/src/loci/formats/in/LegacyQTReader.java | 3 +++ .../formats-bsd/src/loci/formats/out/LegacyQTWriter.java | 3 +++ 3 files changed, 9 insertions(+) diff --git a/components/formats-bsd/src/loci/formats/gui/LegacyQTTools.java b/components/formats-bsd/src/loci/formats/gui/LegacyQTTools.java index be620b37b28..3f6453e01cd 100644 --- a/components/formats-bsd/src/loci/formats/gui/LegacyQTTools.java +++ b/components/formats-bsd/src/loci/formats/gui/LegacyQTTools.java @@ -53,7 +53,10 @@ /** * Utility class for working with QuickTime for Java. + * + * @Deprecated LegacyQTTools will be removed in Bio-Formats 7.0.0 */ +@Deprecated public class LegacyQTTools { // -- Constants -- diff --git a/components/formats-bsd/src/loci/formats/in/LegacyQTReader.java b/components/formats-bsd/src/loci/formats/in/LegacyQTReader.java index 406b04fba53..b0fd6b3d53a 100644 --- a/components/formats-bsd/src/loci/formats/in/LegacyQTReader.java +++ b/components/formats-bsd/src/loci/formats/in/LegacyQTReader.java @@ -57,7 +57,10 @@ * * Much of this code was based on the QuickTime Movie Opener for ImageJ * (available at http://rsb.info.nih.gov/ij/plugins/movie-opener.html). + * + * @Deprecated LegacyQTReader will be removed in Bio-Formats 7.0.0 */ +@Deprecated public class LegacyQTReader extends BIFormatReader { // -- Fields -- diff --git a/components/formats-bsd/src/loci/formats/out/LegacyQTWriter.java b/components/formats-bsd/src/loci/formats/out/LegacyQTWriter.java index 1883dd7dd33..c729fad30db 100644 --- a/components/formats-bsd/src/loci/formats/out/LegacyQTWriter.java +++ b/components/formats-bsd/src/loci/formats/out/LegacyQTWriter.java @@ -52,7 +52,10 @@ * * Much of this code was based on the QuickTime Movie Writer for ImageJ * (available at http://rsb.info.nih.gov/ij/plugins/movie-writer.html). + * + * @Deprecated LegacyQTWriter will be removed in Bio-Formats 7.0.0 */ +@Deprecated public class LegacyQTWriter extends FormatWriter { // -- Constants -- From cc6a6049592348d066afa55557f5fbf15e32e7f3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Besson?= Date: Tue, 4 Jul 2023 15:42:48 +0100 Subject: [PATCH 2/2] Add deprecation warning to NativeQTReader --- .../formats-bsd/src/loci/formats/in/NativeQTReader.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/components/formats-bsd/src/loci/formats/in/NativeQTReader.java b/components/formats-bsd/src/loci/formats/in/NativeQTReader.java index 59767ab81d0..7ccb0eaa5ab 100644 --- a/components/formats-bsd/src/loci/formats/in/NativeQTReader.java +++ b/components/formats-bsd/src/loci/formats/in/NativeQTReader.java @@ -61,7 +61,11 @@ * Additional video codecs will be added as time permits. * * @author Melissa Linkert melissa at glencoesoftware.com + * + * @Deprecated NativeQTReader will be unified with QTReader in Bio-Formats 7.0.0 + * and should no longer be used */ +@Deprecated public class NativeQTReader extends FormatReader { // -- Constants --